Skip to content

Two suggestions #1

@loonychewy

Description

@loonychewy

Thanks for this excellent ANE, its very easy to use! If I could give a couple of suggestions here:

  1. It took me a while to figure out that I need to specify (uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE") in the (manifestAdditions) section of the application descriptor xml. Could this be added to the readme.md?
  2. Noticed that all dispatchStatusEventAsync() calls in SaveInstagramFunction.java and ShInstagramExtensionContext.java returns ("ok", "status"), even if an exception is thrown. Would it be possible to return an error instead when an error occurs, so that the application can handle them?

Edit: Replaced the angle brackets in (1) with round brackets as they aren't being displayed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions