Skip to content

fix(amplitude-session): use eventSessionId in insertSession + remove debug logs #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abueide wants to merge 1 commit into from
Closed

fix(amplitude-session): use eventSessionId in insertSession + remove debug logs #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/plugins/plugin-amplitudeSession/src/AmplitudeSessionPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
this.eventSessionId = this.sessionId;
}

if (eventName === AMP_SESSION_END_EVENT) {
console.log(`[AmplitudeSession] EndSession = ${this.eventSessionId}`);
}

if (
eventName.startsWith('Amplitude') ||
eventName === AMP_SESSION_START_EVENT ||
Expand Down Expand Up @@ -197,7 +193,7 @@ export class AmplitudeSessionPlugin extends EventPlugin {
...event,
integrations: {
...integrations,
[this.key]: { session_id: this.sessionId },
[this.key]: { session_id: this.eventSessionId },
},
};
};
Expand Down Expand Up @@ -255,8 +251,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
this.eventSessionId === -1 ? newSessionId : this.eventSessionId;
this.lastEventTime = newSessionId;

console.log(`[AmplitudeSession] startNewSession -> ${newSessionId}`);

await this.trackSessionStart(newSessionId);
}

Expand All @@ -276,8 +270,6 @@ export class AmplitudeSessionPlugin extends EventPlugin {
return;
}

console.log(`[AmplitudeSession] endSession -> ${this.sessionId}`);

this.analytics?.track(AMP_SESSION_END_EVENT, {
integrations: {
[this.key]: { session_id: sessionId },
Expand Down
28 changes: 28 additions & 0 deletions packages/plugins/plugin-amplitudeSession/src/__tests__/AmplitudeSessionPlugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,34 @@ describe('AmplitudeSessionPlugin', () => {
});
});

it('should use eventSessionId for event enrichment during transition', async () => {
const baseTime = Date.now();
jest.setSystemTime(baseTime);

// Set up a session where eventSessionId differs from sessionId
// (simulates mid-transition state where new session has started but
// eventSessionId still points to the old session)
plugin['_sessionId'] = baseTime;
plugin['_eventSessionId'] = baseTime - 50000;
plugin['_lastEventTime'] = baseTime - 1000;

const mockEvent: TrackEventType = {
type: EventType.TrackEvent,
event: 'test_event',
properties: {},
messageId: 'msg-1',
timestamp: '2023-01-01T00:00:00.000Z',
anonymousId: 'anon-1',
};

const result = await plugin.execute(mockEvent);

// insertSession should use eventSessionId, not sessionId
expect(result.integrations?.['Actions Amplitude']).toEqual({
session_id: baseTime - 50000,
});
});

it('should NOT modify events when session_id already exists', async () => {
const mockEvent: TrackEventType = {
type: EventType.TrackEvent,
Expand Down
Loading