Fix OS command injection in ForkCurl consumer#246
Merged
MichaelGHSeg merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
The User-Agent header values (library name and version) from message context were interpolated directly into a shell command without escaping, allowing arbitrary command execution. Apply escapeshellarg() to the User-Agent header and URL, consistent with how payload and secret are already handled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bsneed
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForkCurlconsumer interpolated user-controlledcontext.library.nameandcontext.library.versionvalues directly into a shell command passed toexec(), enabling arbitrary OS command injection.escapeshellarg()to the User-Agent header and URL arguments, consistent with how$payloadand$secretare already escaped.escapeshellarg()produces identical output for values without shell metacharacters.Test plan
escapeshellarg()output is identical to old manual quoting for standard library values (analytics-php/3.8.1)'; id>&2 #) is properly neutralized🤖 Generated with Claude Code