This repository was archived by the owner on Feb 13, 2024. It is now read-only.
#284 Added options for axiosRetryConfig, disable axiosRetry if retryCount is 0 #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if retryCount is 0
pbassut
suggested changes
Jul 14, 2021
| retryCondition: this._isErrorRetryable, | ||
| retryDelay: axiosRetry.exponentialDelay | ||
| }) | ||
| if (options.retryCount !== 0) { |
Contributor
There was a problem hiding this comment.
here it should be === 0, right?
Contributor
Author
There was a problem hiding this comment.
No? If the user sets a retryCount specifically of 0 then we do not need axiosRetry :)
Contributor
Author
There was a problem hiding this comment.
No worries :D Its always good to double check :)
Appreciate the review!
Co-authored-by: Patrick Bassut <[email protected]>
pbassut
approved these changes
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to write tests but found sinon (or at least sinon at the current version) was not able to spy or stub axiosRetry to allow me to check the options passed in (possibly I was testing the wrong way?)