This repository was archived by the owner on Feb 26, 2021. It is now read-only.
Add Re-Import and tests #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please merge |
SirDany
approved these changes
Aug 19, 2019
J12934
reviewed
Aug 19, 2019
| private String currentDate() { | ||
| return LocalDate.now(clock).format(DateTimeFormatter.ofPattern(DATE_FORMAT)); | ||
| } | ||
| private String currentDateTime() { |
Member
There was a problem hiding this comment.
Does DefectDojo now support more detailed dates (with hour and minutes) for the tests?
If i remember correctly we tried to add them like this but it didn't used to work.
Contributor
Author
There was a problem hiding this comment.
No, only tests needs to be defined with time. As you mostly create it with an engagement, you didn't had contact so far.
J12934
reviewed
Aug 19, 2019
...ctdojo-persistenceprovider/src/main/java/io/securecodebox/persistence/DefectDojoService.java
Outdated
Show resolved
Hide resolved
Member
|
The existing persistence provider functionality works unhindered. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress