Skip to content

Update constraints to be compatible with composite keys defined in the metadata#2828

Merged
frances-h merged 4 commits intofeature/metadata-composite-keysfrom
enterprise-issue-1745-constraints-composite-keys
Mar 2, 2026
Merged

Update constraints to be compatible with composite keys defined in the metadata#2828
frances-h merged 4 commits intofeature/metadata-composite-keysfrom
enterprise-issue-1745-constraints-composite-keys

Conversation

@frances-h
Copy link
Contributor

Resolve datacebo/SDV-Enterprise#1735

@frances-h frances-h self-assigned this Feb 26, 2026
@frances-h frances-h requested a review from a team as a code owner February 26, 2026 15:53
@frances-h frances-h requested review from fealho and gsheni and removed request for a team February 26, 2026 15:53
@frances-h frances-h force-pushed the enterprise-issue-1745-constraints-composite-keys branch from 7d1df4f to ff2d517 Compare February 26, 2026 16:00
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _remove_columns_from_metadata method in sdv.cag._utils doesn't support composite keys. Should that be addressed in this PR?

@sdv-team
Copy link
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@frances-h frances-h force-pushed the feature/metadata-composite-keys branch from fdc2f9d to 799c9ee Compare February 27, 2026 15:29
@frances-h frances-h force-pushed the enterprise-issue-1745-constraints-composite-keys branch from cef7bc9 to e79c4fa Compare February 27, 2026 15:29
@fealho fealho self-requested a review February 27, 2026 16:03
@sdv-team
Copy link
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (b846086) to head (7f7fb7d).
⚠️ Report is 23 commits behind head on feature/metadata-composite-keys.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feature/metadata-composite-keys    #2828       +/-   ##
====================================================================
+ Coverage                            75.41%   98.06%   +22.64%     
====================================================================
  Files                                   73       73               
  Lines                                 8201     8266       +65     
====================================================================
+ Hits                                  6185     8106     +1921     
+ Misses                                2016      160     -1856     
Flag Coverage Δ
integration 75.46% <72.22%> (+0.04%) ⬆️
unit 97.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdv-team
Copy link
Contributor

sdv-team commented Mar 1, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@frances-h frances-h merged commit 10a26ba into feature/metadata-composite-keys Mar 2, 2026
47 checks passed
@frances-h frances-h deleted the enterprise-issue-1745-constraints-composite-keys branch March 2, 2026 13:04
frances-h added a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants