Fix dotplot vcenter=0 ignored due to falsy check#295
Merged
Conversation
`if vcenter:` evaluates to False when vcenter=0, so TwoSlopeNorm was never applied. Changed to `if vcenter is not None:` and added vcenter=0 to the parametrized test. Closes #293 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if vcenter:→if vcenter is not None:in_dotplot.pyso thatvcenter=0correctly appliesTwoSlopeNormvcenter=0to the parametrized test to prevent regressionCloses #293
Test plan
tests/pl/test_dotplot.pypasses with all 3 parametrized values (None,0,3)🤖 Generated with Claude Code