Fixed linting related issues #71#72
Merged
prateek3255 merged 5 commits intoscriptified:mainfrom Oct 13, 2021
Merged
Conversation
added 2 commits
October 3, 2021 12:13
Added eslint rule overrides. Fixed return type issues. ref scriptified#71
gupta-ji6
requested review from
a team,
gupta-ji6 and
prateek3255
and removed request for
a team
prateek3255
requested changes
Oct 3, 2021
Contributor
prateek3255
left a comment
prateek3255
left a comment
There was a problem hiding this comment.
@hinogi Just a few comments other than that everything else looks good. Thanks for working on this 🙌
Co-authored-by: Prateek Surana <prateeksurana3255@gmail.com>
gupta-ji6
added
the
hacktoberfest
hinogi
commented
Oct 4, 2021
Contributor
Author
|
@prateek3255 anything else you need? I see a change request but I don't see where. |
Contributor
|
Thanks for working on this @hinogi ✨. @all-contributors please add @hinogi for code |
Contributor
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 887 |
Member
|
@all-contributors please add @hinogi for code |
Contributor
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 887 |
Member
|
@all-contributors please add @hinogi for code |
Contributor
|
I've put up a pull request to add @hinogi! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some overrides to the eslint config which was reporting some false positives.
I ran prettier on all files to get rid of most of the errors.
I fixed mostly return type related issues and some missing or incomplete types.
Fixes #71