refactor: share link a11y label fixes & refactor#60
refactor: share link a11y label fixes & refactor#60gupta-ji6 merged 6 commits intoscriptified:mainfrom anuraghazra:share-link-refactor
Conversation
| label="Share to Twitter" | ||
| text="Share to Twitter" | ||
| url={twitterShareURL} | ||
| icon={<TwitterIcon color={`text-${theme}-500`} />} |
There was a problem hiding this comment.
Also are you guys manually adding these colors to tailwind purge? because dynamically interpolating like this purgecss won't be able to detect them.
There was a problem hiding this comment.
@anuraghazra Yes, we have a script that extracts the classes that are using the theme variable and then generates purgeable classnames with all possible themes from them. Also, I am not sure if you remember it, but we also had a conversation regarding this on Twitter 😁, the repo wasn't public back then, so I wasn't able to share the code.
There was a problem hiding this comment.
Ohhhh hahaha that was a quick round-about of thoughts. yeah I remember. Pretty cool!
| const Logo = LINK_LOGO[link]; | ||
| return ( | ||
| <a | ||
| aria-label={`Go to ${siteConfig.name}'s ${link} profile`} |
There was a problem hiding this comment.
Announcing "Got to" for each link is a bit redundant/annoying for screenreader users.
There was a problem hiding this comment.
you're right, even repeating "Scriptified's" is also redundant and quite obvious.
just "${link} profile" looks appropriate to me. thoughts @prateek3255?
|
@anuraghazra Sorry for responding so late, we weren't watching this repo so we weren't notified about the pull request, and that's why we missed it 😅 |
prateek3255
left a comment
prateek3255
left a comment
There was a problem hiding this comment.
Thanks for the contribution @anuraghazra 💪🏻. Apart from this one small change, this PR LGTM ✅
public/service-worker.js
Outdated
| }); | ||
| workbox.precacheAndRoute( | ||
| [ | ||
| { |
There was a problem hiding this comment.
Can you remove these files from the changes, these are auto-generated files generated by next-pwa, we might have missed git ignoring them
There was a problem hiding this comment.
Sure will do ASAP.
|
@all-contributors please add @anuraghazra for code & a11y |
|
I've put up a pull request to add @anuraghazra! 🎉 |
3 participants
No description provided.