Improve source layout test discovery #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When `./tests` is present, try to test that instead of packagename - If src layout is used, there's no need to switch away from the source directory when testing - No longer use import-mode=importlib, which meant that packages could not do relative imports in tests
stefanv
force-pushed
the
improve-src-test-discovery
branch
from
3aa0a00 to
7303f9d
Compare
Contributor
|
Thanks so much for working on this! Let me know if you need anything from me on the NumPy side of things to get this in and update NumPy's CI to spin 0.13 afterwards. |
stefanv
added a commit
that referenced
this pull request
Nov 12, 2024
- When `./tests` is present, try to test that instead of packagename - If src layout is used, there's no need to switch away from the source directory when testing - No longer use import-mode=importlib, which meant that packages could not do relative imports in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to move forward with numpy/numpy#27371 without breaking behavior for
src/testslayout.