Improve debug printing for Meson editable installs #192
Conversation
spin/cmds/pip.py
Outdated
| pip_args += ["--no-build-isolation"] | ||
| if editable: | ||
| pip_args += ["--editable"] | ||
| if verbose: |
There was a problem hiding this comment.
Thanks for this PR!
I find it a tiny bit weird to mix two slightly different things:
- verbose for pip commands, I want to see the output of the
pipcommand - verbose for meson editable install: I want to see the compilation steps when importing the package (if there is anything to recompile)
Maybe I want to see the compilation output the first time (pip verbose) but not on import (meson editable verbose)
A separate parameter like --meson-editable-verbose for the spin install command would maybe make sense?
There was a problem hiding this comment.
Sure, let's split the options.
stefanv
force-pushed
the
verbose-editable-install
branch
from
9280ce6 to
88457cd
Compare
There was a problem hiding this comment.
Tested this PR on my scikit-learn branch from scikit-learn/scikit-learn#29012, this seems to work fine, thanks!
I will trust you on the naming, I proposed --meson-editable-verbose initially, but I would agree that --verbose-import is more easily understandable for most people and also shorter.
You know how it is with naming. There's no right or wrong, but everyone's got an opinion :) I chose this to keep it short, and in case we could retrofit it in the future to CMake and other build types. |
|
Thanks for this! Just curious, what's the rough timeline for the 0.10 release? This is mostly so that I remember to update scikit-learn/scikit-learn#29012. |
|
0.10 should be out by tomorrow. |
|
Great thanks! |
|
Release is out. |
|
Thanks! |
3 participants
No description provided.