Conversation
Design for instrumenting model endpoint startup to capture detailed timing metrics (pod scheduling, model download, vLLM init, server ready) using OpenTelemetry with Datadog as the visualization layer. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes: - Allow gpus=0 with gpu_type=None for CPU-only endpoints - Add validate_cpu_only_framework to ensure only vLLM supports CPU - Update validate_num_shards to require num_shards=0 for CPU-only - Set vLLM args for CPU mode: device=cpu, dtype=float32, tensor_parallel_size=1 - Add 'device' field to VLLMModelConfig - Fix type narrowing in execute() for mypy Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add tests for validate_num_shards and validate_cpu_only_framework to cover the new CPU-only endpoint support. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- derive cpu_only bool at entry points for clearer internal logic - validate_cpu_only_framework now takes cpu_only: bool directly - validate_num_shards derives cpu_only internally from gpus - _create_vllm_bundle_command derives cpu_only from num_shards==0 - Update tests to use named parameters for clarity Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.