[build] Restore dist projects required for Scala runners
#24775
Merged
+161
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
changed the title
dist required for Scala runnersdist projects required for Scala runners
WojciechMazur
added
the
backport:nominated
Contributor
Author
|
When it's merge I'd publish a followup PR which restores scaladoc tests - it requires universal distribution provided by this PR. Non boostrapped scaladoc was not tested, it's tests now fail to compile due to -Yexplicit-nulls and some tests fail due to scala-library changes (no more Scala 2.13 on the classpath) |
tgodzik
approved these changes
Dec 19, 2025
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Had a quick look and from my side LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the dist build and sets up some minimal tests around them
One potential regression/progression -
scala3-replentries is no longer available on the classpath underscala --with-compilerwhen compared with3.7.4I'm not sure if it's expected. It's caused by extraction of repl to seperate artifact. It feels like a good direction, users should not need to depend on repl in the same way as they don't need to depend on scaladoc internals.