Fix #9166: Harden check for values in patterns based on class inheritance info #11784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-9166
branch
5 times, most recently
from
8123de4 to
9e54dbe
Compare
smarter
approved these changes
Mar 17, 2021
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 4, 2023
The original PR fixes a trivial issue. However, the fix has both false positives and negatives. It's not easy to do the right thing. Therefore, it's simpler to remove the original fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9166: Harden check for values in patterns based on class inheritance info