Skip to content

Conversation

@opensyria
Copy link
Contributor

@opensyria opensyria commented Dec 31, 2025

.

@prusnak
Copy link
Member

prusnak commented Dec 31, 2025

9633 in hex is 25a1

please fix

and next time add to your checklist - i have checked that dec and hex values match

@opensyria
Copy link
Contributor Author

Thank you for catching the hex mismatch!

I've pushed a fix:

  • Incorrect: 0x80002599
  • Correct: 0x800025A1

Verification:

9633 (decimal) = 0x25A1 (hex)
0x80000000 + 0x25A1 = 0x800025A1 ✓

I've also updated the PR description with:

  • Clear conversion verification
  • A new checklist item confirming decimal/hex validation

Appreciate the thorough review — this will help ensure accuracy in future submissions.

@prusnak
Copy link
Member

prusnak commented Jan 4, 2026

user lowercase letters for hex values

@opensyria
Copy link
Contributor Author

Fixed - updated to lowercase: 0x800025a1. Thanks for the review!

@prusnak prusnak merged commit e42e029 into satoshilabs:master Jan 4, 2026
@opensyria opensyria deleted the Add-OpenSY-(SYL)---Coin-Type-9633-n branch January 4, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants