Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
- Coverage 98.18% 98.04% -0.15%
==========================================
Files 37 37
Lines 4517 4547 +30
==========================================
+ Hits 4435 4458 +23
- Misses 82 89 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning just the dry array of data from Storage methods, return an object that contains
dataand acountfor the total count of records returned. This opens up opportunities for further metadata to be included later.Still a bit woolly around how the
deletemethod communicates data-less success, but this can be improved later.The MongoDB driver will have to change a little bit too to accommodate these adjustments.
Closes #171.