Skip to content

Conversation

@laritakr
Copy link
Contributor

Fixes

Moves flexible schema loading behavior into the ChangeSet class from the ResourceForm class, so that it applies to all change sets, not just forms.

This fixes an issue where properties defined in a flexible schema were not being set on the change set when not using a form from the workflow's action taken service, and allows works created using mediated deposit to complete the workflow's transaction steps.

Fixes samvera/hyku#2769

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Test Results

    1 files   -     12      1 suites   - 12   0s ⏱️ - 2h 57m 13s
    2 tests  -  6 899      0 ✅  -  6 588  0 💤  - 312  2 ❌ +1 
1 775 runs   - 16 563  1 773 ✅  - 16 048  0 💤  - 516  2 ❌ +1 

For more details on these failures, see this check.

Results for commit 9e6f6b4. ± Comparison against base commit eee6d30.

This pull request removes 6901 and adds 2 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efd7d4af3e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f34667a2e60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f63f74dd340>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efd7d2871d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3466858350>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f63dfeb85d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 960cf192-2071-4c4f-b7c1-012f02755c3b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 69ead043-f418-40a9-8966-8994e57606ca
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: e7a21f78-b96a-4ee7-a785-44478633cd82
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: edd6a5e2-bc08-4796-836d-c5dbc684fa13
…
app.models.hyrax.change_set ‑ Layout/EmptyLinesAroundClassBody
app.models.hyrax.change_set ‑ Layout/LineLength

♻️ This comment has been updated with latest results.

laritakr added a commit that referenced this pull request Dec 22, 2025
Pulls in changes from #7322
to make ChangeSet support flexible schema. Moves relevant logic
up a level from resource_form.
@laritakr laritakr force-pushed the make-change-set-flexible branch from 14b8f5e to 9e6f6b4 Compare December 22, 2025 22:33
Moves flexible schema loading behavior into the ChangeSet class from the
ResourceForm class, so that it applies to all change sets, not just forms.

This fixes an issue where properties defined in a flexible schema were not
being set on the change set when not using a form from the workflow's
action taken service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants