This repository was archived by the owner on Jul 20, 2020. It is now read-only.
compatible with Swift5 and Data conversion issue fixed.#46
Open
shraza wants to merge 1 commit intoryanfowler:masterfrom
Open
compatible with Swift5 and Data conversion issue fixed.#46shraza wants to merge 1 commit intoryanfowler:masterfrom
shraza wants to merge 1 commit intoryanfowler:masterfrom
Conversation
Data insertion was causing a crash at line number 1307
moizirshad
approved these changes
Oct 31, 2019
moizirshad
left a comment
moizirshad
left a comment
There was a problem hiding this comment.
This code is working fine on Swift 5, iOS 13, XCode 11.
Good work.
Appreciated (Y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data insertion was causing a crash at line number 1307
Data conversion was not in the hex string format and converted string was something like this
"{ length = someLength, bytes= dataBytes}"
so when this code "X'(newStr)'" executes it leads to a crash because it has some not allowed characters in the string