Conversation
djc
commented
Jun 5, 2025
| /// See the documentation for [rustls-platform-verifier] for more details. | ||
| /// | ||
| /// [rustls-platform-verifier]: https://docs.rs/rustls-platform-verifier | ||
| #[cfg(feature = "rustls-platform-verifier")] |
Member
Author
There was a problem hiding this comment.
This is technically not semver compatible, since we didn't seal our extension trait. It seems unlikely that anyone actually implemented it?
Should we consider deprecating with_native_roots() to try and get more people to use the platform verifier?
ctz
approved these changes
Jun 5, 2025
Member
ctz
left a comment
ctz
left a comment
There was a problem hiding this comment.
Do we want to seal ConfigBuilderExt? I think that would make this a non-breaking change.
Member
Author
In the future, yes -- sealing it would be breaking now. |
djc
force-pushed
the
platform-verifier-0.6
branch
from
97d6f1c to
bd42b90
Compare
This is technically semver-breaking, but we think it's unlikely that anyone has actually implemented the trait.
djc
force-pushed
the
platform-verifier-0.6
branch
from
bd42b90 to
60cfcc2
Compare
ctz
approved these changes
Jun 6, 2025
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed release notes
ConfigBuilderExttrait. This is an extension trait used to offer a more convenient server verifier configuration API. This is technically a breaking change, but we think it is unlikely that anyone has actually implemented this trait.