Fix https_only/enforce_https enforcement#295
Merged
djc merged 1 commit intorustls:mainfrom Dec 19, 2024
Merged
Conversation
saleemrashid
force-pushed
the
fix-enforce-https
branch
from
17fdefa to
1f0b73f
Compare
ctz
approved these changes
Dec 19, 2024
djc
reviewed
Dec 19, 2024
Member
|
Thanks for fixing this -- and sorry for breaking it in the first place! |
saleemrashid
force-pushed
the
fix-enforce-https
branch
from
1f0b73f to
ddceeb3
Compare
cpu
approved these changes
Dec 19, 2024
Merged
This was referenced May 21, 2025
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
May 21, 2025
This is how it should've been before. The only reason it worked was that `https_only` was not really enforced. See here: rustls/hyper-rustls#295
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the check for
self.force_httpswas removed in b7ae349,HttpsConnectorBuilder::https_only/HttpsConnector::enforce_httpshave been no-ops.This pull request restores the old behavior and adds some tests.