fix: add rustls-platform-verifier flag for importing ConfigBuilderExt

[junkurihara]

Hello! Thank you so much for actively developing!

I found a (maybe) potential bug when I import hyper-rustls with rustls-platform-verifier feature. If hyper-rustls with rustls-platform-verifier (+aws-lc-rs or ring) and default-features = false, we cannot build the following code

let client =  hyper_rustls::HttpsConnectorBuilder::new().with_platform_verifier()

with error message: "no method named with_platform_verifier found for struct ConfigBuilder in the current scope".

The reason why this build failure occurs is that in src/connector/builder.rs, ConfigBuilderExt is imported only when either one of rustls-native-certs or webpki-roots is enabled. Thus, I fixed the code a bit (just added feature flag).

Of course I know that feature rustls-platform-verifier is not public on README.md and that native-tokio, i.e., rustls-native-certs, seems to be prioritized over the feature. But I am very happy if this would be considered! Thank you.

Jun

[djc]

This was just an oversight, thanks!

[djc]

Of course I know that feature rustls-platform-verifier is not public on README.md and that native-tokio, i.e., rustls-native-certs, seems to be prioritized over the feature. But I am very happy if this would be considered! Thank you.

Those are just oversights, too -- happy if you want to send another PR for adding it in README.md. In a future semver-incompatible release I think we'll want to make rustls-platform-verifier the default for clients.

[junkurihara]

Hi, thank you for the approval!

Those are just oversights, too -- happy if you want to send another PR for adding it in README.md.

Yes, I will make a PR to add rustls-platform-verifier feature in README.md. after getting merged this PR :)

I n a future semver-incompatible release I think we'll want to make rustls-platform-verifier the default for clients.

Yes please! In my opinion, a dedicated feature name is nicer to enable rustls-platform-verifier, e.g., platform-tokio, much like the mapping native-tokio -> rustls-native-certs.

Thanks!

[cpu]

Good catch, thank you