Merged
Conversation
Member
|
It might be nice to bring the semver check CI task to this repo. I gave the diff a once over and briefly paused on this visibility change. After seeing the context it was made in (unreachable pub), it seems OK but it also made me realize we're missing that CI guard rail here. Do you want to fold that into this branch or would it be helpful if I did that in a separate PR? |
cpu
approved these changes
Oct 26, 2023
Member
Author
|
Would be great if you can submit a PR for that. |
Member
Author
|
Published to crates.io. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone asked for this privately in order to help avoid duplicate dependencies (in particular, webpki-roots).
Proposed release notes
enable_all_versions()based on enabled versionsAcceptorBuilder::with_acceptor()builder method