Merged
Conversation
Probably don't need daily runs given the amount of changes. Run on Friday mornings so we can catch clippy changes from Rust releases that happen on Thursday relatively soon after. Also include merge group support.
cpu
approved these changes
Aug 14, 2023
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Thanks for the many cleanup commits (and adding cron CI!).
This looks good to me. I had one question about the MSRV increase but I don't think it's blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218 and maybe also addresses #198?