Adjust how native static libraries are linked

[retep998]

Switch from link_whole_staticlib to link_staticlib because we now pass explicit lists of what to export to the linker on all platforms so theoretically it should work.
Ensure that hint_static is used appropriately for all static libraries, including static-nobundle, not just static.

r? @alexcrichton
cc @vadimcn

[frewsxcv]

Any reason for the collect?

[retep998]

Not really, so I removed it.

[retep998]

Hmmmm, it looks like linking the whole staticlib is still necessary for librustc_llvm.

[alexcrichton]

Oh right, I don't think we past a list of symbols when creating dylibs on Unix platforms (only on Windows). For cdylibs I think we past the list on all platforms.

[vadimcn]

Any reason to not always use an explicit export list? Are there linkers that do not support them?

[alexcrichton]

Unsure, if we can get it to work then we can get it to work. Very little of src/librustc_trans/back/*.rs is anything beyond "this was the first thing that landed"

[alexcrichton]

ping @retep998, any update on this?

[retep998]

#40805 does the changes to hinting in a way which I think is better. It doesn't however attempt to switch from whole_staticlib to simply staticlib, so I'll investigate whether it is possible to use an explicit export list for dylibs everywhere.

[alexcrichton]

Ok, in the meantime I'm going to close this, but we can reopen/resubmit when tests are passing