Fix min-specialization ICE from ignored region resolution failure#155159
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Apr 12, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? me @bors r+ rollup |
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2026
Rollup of 7 pull requests Successful merges: - #155084 (Initial functions to start on transmute v2) - #155126 (add `cfg(target_object_format = "...")`) - #155165 (Portable SIMD subtree update) - #153871 (fix spurious test failure in `metadata_access_times`) - #155150 (replace <name> @ ty::AliasTy matches with just using args: <name>_args) - #155159 (Fix min-specialization ICE from ignored region resolution failure) - #155167 (Reduce size of `ImportData`)
rust-timer
added a commit
that referenced
this pull request
Apr 12, 2026
Rollup merge of #155159 - TaKO8Ki:min-specialization-next-solver-region-resolution, r=Kivooeo Fix min-specialization ICE from ignored region resolution failure Fixes #151327 `min_specialization::get_impl_args` resolved regions and then immediately called `fully_resolve`, but it ignored failures from `resolve_regions_and_report_errors`. Propagate the region-resolution error instead of ignoring it. That matches the pattern used in: https://github.com/rust-lang/rust/blob/40a3ed1e1407ebbe892ce1a74128482ea1dadf7a/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs#L706 https://github.com/rust-lang/rust/blob/40a3ed1e1407ebbe892ce1a74128482ea1dadf7a/compiler/rustc_hir_analysis/src/coherence/builtin.rs#L421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151327
min_specialization::get_impl_argsresolved regions and then immediately calledfully_resolve, but it ignored failures fromresolve_regions_and_report_errors.Propagate the region-resolution error instead of ignoring it. That matches the pattern used in:
rust/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs
Line 706 in 40a3ed1
rust/compiler/rustc_hir_analysis/src/coherence/builtin.rs
Line 421 in 40a3ed1