cg_llvm: More preparation for moving FFI bindings to rustc_llvm
#147430
+72
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
Collaborator
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #147453) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #147629) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
Member
|
r? rust-lang/compiler |
Member
|
@bors r=chenyukang |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
I haven't touched this in a while, so I'll rebase it to check that nothing unexpected has happened in the meantime. @bors r- |
bors
added
S-waiting-on-author
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Looks good still. @bors r=chenyukang |
Collaborator
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 19, 2025
cg_llvm: More preparation for moving FFI bindings to `rustc_llvm` - Sequel to rust-lang#147327 - Motivated by rust-lang#142897 --- This is another batch of adjustments to code that would otherwise interfere with moving FFI bindings out of `rustc_codegen_llvm` and into `rustc_llvm`.
bors
added a commit
that referenced
this pull request
Dec 19, 2025
…uwer Rollup of 4 pull requests Successful merges: - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`) - #149815 (Add regression test for #120189) - #149947 (add several older crashtests) - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 19, 2025
Rollup of 3 pull requests Successful merges: - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`) - #149815 (Add regression test for #120189) - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 19, 2025
Rollup of 3 pull requests Successful merges: - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`) - #149815 (Add regression test for #120189) - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 19, 2025
Rollup merge of #147430 - Zalathar:inherent, r=chenyukang cg_llvm: More preparation for moving FFI bindings to `rustc_llvm` - Sequel to #147327 - Motivated by #142897 --- This is another batch of adjustments to code that would otherwise interfere with moving FFI bindings out of `rustc_codegen_llvm` and into `rustc_llvm`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another batch of adjustments to code that would otherwise interfere with moving FFI bindings out of
rustc_codegen_llvmand intorustc_llvm.