Skip to content

Conversation

@Voultapher
Copy link

Companion PR for rust-lang/rust#139493

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Nov 8, 2025
@traviscross traviscross added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Nov 9, 2025
@rustbot

This comment has been minimized.

@Voultapher Voultapher force-pushed the explicitly-export-core-and-std-macros branch from 1e9df55 to afed4f6 Compare November 15, 2025 10:06
@Voultapher
Copy link
Author

I've updated the PR, it's not clear to me what changes are still desired please re-review.

@ehuss
Copy link
Contributor

ehuss commented Nov 15, 2025

Can you rebase on latest master now that #1913 has been merged?

I would suggest the following edits:

diff --git a/src/names/preludes.md b/src/names/preludes.md
index 3a2c3ff1..b25b4b8a 100644
--- a/src/names/preludes.md
+++ b/src/names/preludes.md
@@ -81,7 +81,7 @@ r[names.preludes.extern.no_std]
 ### The `no_std` attribute

 r[names.preludes.extern.no_std.intro]
-The *`no_std` [attribute][attributes]* causes the [`std`] crate to not be linked automatically, the [standard library prelude] to instead use the `core` prelude, and the [`macro_use` prelude] to instead use the macros exported from the `core` crate.
+The *`no_std` [attribute][attributes]* causes the [`std`] crate to not be linked automatically and the [standard library prelude] to instead use the `core` prelude.

 > [!EXAMPLE]
 > <!-- ignore: test infrastructure can't handle no_std -->
@@ -110,9 +110,6 @@ The `no_std` attribute may be used any number of times on a form.
 r[names.preludes.extern.no_std.module]
 The `no_std` attribute changes the [standard library prelude] to use the `core` prelude instead of the `std` prelude.

-r[names.preludes.extern.no_std.macro_use]
-By default, all macros exported from the `std` crate are added to the [`macro_use` prelude]. If the `no_std` attribute is specified, then all macros exported from the `core` crate are placed into the [`macro_use` prelude] instead.
-
 r[names.preludes.extern.no_std.edition2018]
 > [!EDITION-2018]
 > Before the 2018 edition, `std` is injected into the crate root by default. If `no_std` is specified, `core` is injected instead. Starting with the 2018 edition, regardless of `no_std` being specified, neither is injected into the crate root.

@Voultapher Voultapher force-pushed the explicitly-export-core-and-std-macros branch from afed4f6 to 6e5f0ec Compare November 17, 2025 17:24
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Voultapher
Copy link
Author

My bad, I had forgotten to track upstream. First PR in this repo.

@Voultapher
Copy link
Author

I've applied your feedback and added a section to name-resolution.md

@Voultapher Voultapher force-pushed the explicitly-export-core-and-std-macros branch from 6e5f0ec to 3eb47c5 Compare November 17, 2025 17:26
@Voultapher Voultapher force-pushed the explicitly-export-core-and-std-macros branch from 3eb47c5 to 60b5203 Compare November 17, 2025 17:28
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

☔ The latest upstream changes (possibly 4d81027) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: The marked PR is awaiting review from a maintainer S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants