Added content release select.#5
Open
othermachines wants to merge 1 commit intorudyrigot:masterfrom
othermachines:content_release_select
Open
Added content release select.#5othermachines wants to merge 1 commit intorudyrigot:masterfrom othermachines:content_release_select
othermachines wants to merge 1 commit intorudyrigot:masterfrom
othermachines:content_release_select
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to partially resolve #3 with the addition of a content release select. Hopefully my "angular-ish" is OK; I'm open to suggestions. As this is a starter kit, in the controller I included an optional page refresh option using
$window.location.href(commented out).FWIW, I'll include the jsFiddle which contains the relevant bits: http://jsfiddle.net/othermachines/Lckpoy5u/
Note that although I'm not a fan of tabs for indentation, the particular file at app/js/controllers.js does contain tabs, so I stuck with that convention in this instance. Cheers -