feat: Add Frame#frame_element method#524
Merged
route merged 1 commit intorubycdp:mainfrom Mar 5, 2025
Merged
Conversation
This was referenced Feb 23, 2025
myabc
force-pushed
the
feature/frame_node
branch
from
ec42195 to
929ce03
Compare
route
reviewed
Mar 4, 2025
Faciliates easier retrieval of the `iframe` element that embeds the `window` (represented as a `Frame` object by Ferrum).
myabc
force-pushed
the
feature/frame_node
branch
from
929ce03 to
5384c0a
Compare
myabc
changed the title
Frame#node methodFrame#frame_element method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes commit from #523 - please review/merge that PR first.Faciliates easier retrieval of the
iframeelement that embeds thewindow(represented as aFrameobject by Ferrum).This is extracted from my Cuprite PR here: rubycdp/cuprite#291 (that PR doesn't currently depend on this PR being merged, but the Cuprite PR could easily be adapted to call the newly-added Ferum
Frame#nodemethod).