Allows disable javascript from HTML source in the page#407
Merged
route merged 2 commits intorubycdp:mainfrom Sep 26, 2023
erickgskovik:disable-js
Merged
Allows disable javascript from HTML source in the page#407route merged 2 commits intorubycdp:mainfrom erickgskovik:disable-js
route merged 2 commits intorubycdp:mainfrom
erickgskovik:disable-js
Conversation
route
reviewed
Sep 25, 2023
lib/ferrum/page.rb
Outdated
| # This doesn't prevent users evaluate JavaScript with Ferrum. | ||
| # | ||
| def disable_javascript | ||
| command("Emulation.setScriptExecutionDisabled", slowmoable: false, value: true) |
Member
|
Oh a couple things to add, we need to add Changelog entry and a line to README about this new method. |
Contributor
Author
|
@route Ah, right! I assume that you will delegate the function from browser to the page as well. |
route
approved these changes
Sep 26, 2023
Member
|
Yep, all good, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional security measure for users not needing JavaScript.
Fixes #389