Raise Ferrum::StatusError for any top frame navigation error#341
Merged
route merged 1 commit intorubycdp:mainfrom Feb 16, 2023
francisbeaudoin:statuserror-navigation
Merged
Raise Ferrum::StatusError for any top frame navigation error#341route merged 1 commit intorubycdp:mainfrom francisbeaudoin:statuserror-navigation
Ferrum::StatusError for any top frame navigation error#341route merged 1 commit intorubycdp:mainfrom
francisbeaudoin:statuserror-navigation
Conversation
route
approved these changes
Feb 16, 2023
Member
|
Thank you! Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
Page#go_tois only raising aFerrum::StatusErrorfor a subset of exceptions:ferrum/lib/ferrum/page.rb
Lines 113 to 124 in 0cab51d
Per the Chrome DevTools documentation an
errorTextis present if and only if navigation has failed.Proposal
This PR is proposing to raise regardless of the
errorTextgiven that the navigation failed.Reference
Discussion: #340