Skip to content

Handle nil request in Exchange#navigation_request?#339

Merged
route merged 1 commit intorubycdp:mainfrom
Shopify:fix-exchange-navigation-request-nil
Feb 11, 2023
Merged

Handle nil request in Exchange#navigation_request?#339
route merged 1 commit intorubycdp:mainfrom
Shopify:fix-exchange-navigation-request-nil

Conversation

@francisbeaudoin
Copy link
Copy Markdown
Contributor

Details

As the Exchange object is pushed to the network traffic before assigning its request, it is assumed that the request can be nil in the exchange object.

exchange = select(request.id).last
exchange = build_exchange(request.id) unless exchange&.blank?

exchange.request = request

For that reason, the #navigation_request? method was updated to be nil safe.

@route route merged commit 0cab51d into rubycdp:main Feb 11, 2023
@francisbeaudoin francisbeaudoin deleted the fix-exchange-navigation-request-nil branch February 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants