Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions lib/capybara/cuprite/browser/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
module Capybara::Cuprite
class Browser
class Client
class IdError < RuntimeError; end

def initialize(browser, ws_url)
@command_id = 0
@subscribed = Hash.new { |h, k| h[k] = [] }
@browser = browser
@commands = Queue.new
@commands = {}
@mutex = Mutex.new
@resource = ConditionVariable.new
@ws = WebSocket.new(ws_url, @browser.logger)

@thread = Thread.new do
Expand All @@ -21,11 +22,12 @@ def initialize(browser, ws_url)
if method
@subscribed[method].each { |b| b.call(params) }
else
@commands.push(message)
@mutex.synchronize do
@commands[message["id"]] = message
@resource.broadcast
end
end
end

@commands.close
end
end

Expand All @@ -36,14 +38,20 @@ def command(method, params = {})
end

def wait(id:)
message = Timeout.timeout(@browser.timeout, TimeoutError) { @commands.pop }
message = nil
Timeout.timeout(@browser.timeout, TimeoutError) do
message = @mutex.synchronize { @commands.delete(id) }
while !message
message = @mutex.synchronize do
@resource.wait(@mutex)
@commands.delete(id)
end
end
end
raise DeadBrowser unless message
raise IdError if message["id"] != id
error, response = message.values_at("error", "result")
raise BrowserError.new(error) if error
response
rescue IdError
retry
end

def subscribe(event, &block)
Expand Down