Give better errors for some permission issues#4965
Conversation
|
I'd like to ask for some opinions here. Is it to much to automatically grant permissions on the installation folder if we can? |
1995148 to
d93cc26
Compare
|
This a weird MacOS failure (only happens on 2.5, 2.6, and 2.7, but not on 3.0) that I need to investigate. But in addition to that, I'm going to tweak the fix. I think it's fine that bundler tries to automatically fix permissions so that it's able to delete an existing gem folder before reinstalling a gem. But this shouldn't be the default So for now, I won't be changing |
Instead of showing the bug report place with an error at a randome place.
d93cc26 to
db8beab
Compare
|
I updated this PR with the more minimal approach to improve the issue. We don't automatically try to fix any permissions for now, but we now give a proper error instead of throwing a bug report template at random places. I'm setting this PR to close all permission issues. We'll probably get new issues but with better errors where the culprit will be easier to investigate and what to do about them will be more clear. |
7bc2dd8 to
b405550
Compare
Instead of showing the bug report template with an error at a random place.
d98c24a to
882ad3a
Compare
Give better errors for some permission issues (cherry picked from commit 4b5ffab)
What was the end-user or developer problem that led to this PR?
Sometimes bundler fails to do what it needs to do regarding some file operations like creating the gem folder where a gem will be installed, or deleting the previous installation. In some of those cases, bundler fails to report a proper error and instead prints a bug report template with a different error at random places.
What is your fix for the problem, implemented in this PR?
The fix is to properly detect where the actual problem happens, and give a proper error.
Closes #4888.
Closes #4938.
Closes #4939.
Closes #4981.
Make sure the following tasks are checked