Refactor undo redo #809
Merged
Refactor undo redo #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old_input_lines does not need to be an instance variable anymore. Confusing naming of 'input_lines' that stores backup state for undo/redo is renamed to undo_redo_history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
@old_input_linesto a local variableRename
@input_lines@input_lines_positionto@undo_redo_history@undo_redo_indexRename
def push_input_linestodef push_undo_redo. (we havedef move_undo_redo)The meaning of
input_linesis similar to buffer_of_lines and confusing.