Skip to content

Add RFC2396_PARSER to URI module#2727

Merged
ksss merged 1 commit intoruby:masterfrom
sled:add-RFC2396_PARSER-to-URI-module
Dec 8, 2025
Merged

Add RFC2396_PARSER to URI module#2727
ksss merged 1 commit intoruby:masterfrom
sled:add-RFC2396_PARSER-to-URI-module

Conversation

@sled
Copy link
Copy Markdown
Contributor

@sled sled commented Dec 3, 2025

The URI module defines the constant URI::RFC2396_PARSER here but it was missing in the RBS declaration, so I got the following warning:

URI::RFC2396_PARSER.escape("https://example.org")
something.rb:32:29: [warning] Cannot find the declaration of constant: `RFC2396_PARSER`
│ Diagnostic ID: Ruby::UnknownConstant
│
└         URI::RFC2396_PARSER.escape("https://example.org")

@sled sled force-pushed the add-RFC2396_PARSER-to-URI-module branch from 0f40848 to 071edb4 Compare December 3, 2025 21:35
@sled
Copy link
Copy Markdown
Contributor Author

sled commented Dec 3, 2025

Rubocop causes a segmentation fault, I guess this is unrelated to the change.

@ksss ksss merged commit 8fafe58 into ruby:master Dec 8, 2025
32 of 33 checks passed
@ksss ksss added this to the RBS 4.0 milestone Dec 8, 2025
@ksss
Copy link
Copy Markdown
Collaborator

ksss commented Dec 8, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants