Skip to content

Avoid overloading where arguments are identical #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksss merged 2 commits into from
Jun 21, 2025
Merged

Avoid overloading where arguments are identical #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ee0937
Avoid overloading where arguments are identical
ksss Jun 19, 2025
bcf6bcf
Fix path
ksss Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/encoding.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,8 +923,9 @@ class Encoding::Converter < Object
# p ec.primitive_convert(src, dst, nil, 1) #=> :destination_buffer_full
# p ec.last_error #=> nil
#
def last_error: () -> Encoding::InvalidByteSequenceError?
| () -> Encoding::UndefinedConversionError?
def last_error: () -> ( Encoding::InvalidByteSequenceError
| Encoding::UndefinedConversionError
| nil )

# <!--
# rdoc-file=transcode.c
Expand Down
3 changes: 1 addition & 2 deletions core/range.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,8 +930,7 @@ class Range[out Elem] < Object
#
# Related: Range#count.
#
def size: () -> Integer?
| () -> Float?
def size: () -> (Integer | Float | nil)

# <!--
# rdoc-file=range.c
Expand Down
4 changes: 2 additions & 2 deletions stdlib/ripper/0/ripper.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ class Ripper
# - to_a()
# -->
#
def to_a: () -> [ [ Integer, Integer ], Symbol, String, Ripper::Lexer::State, String ]
| () -> [ [ Integer, Integer ], Symbol, String, Ripper::Lexer::State ]
def to_a: () -> ( [ [ Integer, Integer ], Symbol, String, Ripper::Lexer::State, String ]
| [ [ Integer, Integer ], Symbol, String, Ripper::Lexer::State ] )
end

class State
Expand Down