Fix incorrect exception when exponent is fractional for Infinity base #453
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Nov 10, 2025
tompng
approved these changes
Nov 11, 2025
Member
tompng
left a comment
tompng
left a comment
There was a problem hiding this comment.
Thank you 👍
(CI failure in ruby-2.5 and 2.6 is not related to this change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
powerwhen the base is+Infinityand the exponent is a positive fractional exponent.Since v3.3.0,
(+Infinity) ** (positive fractional exponent)raised aFloatDomainErrorinstead of returning+Infinity. The failure came from the precision-preserving path that estimates precision viay*log(x): for positive fractionaly, the code enters this estimator and, withx = +Infinity,Math.log10(x.exponent)can evaluate to-Infinity. Attempting to round that non-finite value triggered the exception.I considered an early-exit approach, but I’m not confident about the mathematical implications, so I made the estimator Infinity-aware instead.