Fix to_f underflow check when DECDIG is uint16_t #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
(Some test already passes now, some test that still fail seems not a bug or a bug also in DECDIG=uint32_t)
When DECDIG is
uint32_t,eis a multiple of 9. (example: -315, -324)In this case, result of wrong calculation
(e < (SIGNED_VALUE)(DBL_MIN_10_EXP-9))and correct calculation(e < (SIGNED_VALUE)(DBL_MIN_10_EXP-15))was the same just by chance.