Specify certfile to verify SSL certs against in tests#166
Conversation
cc @jch as I'm unsure if we want to go this route or make the cert verifiable instead
|
Updated title to match the changed approach. |
There was a problem hiding this comment.
Alternatively, we could generate a CA file if none is found instead of sticking one in test fixtures. Unsure if that'd be any better, though.
There was a problem hiding this comment.
You might consider generating certificates (with e.g. certificate_authority or OpenSSL itself) rather than checking one into the repo
There was a problem hiding this comment.
Yeah, considered this, though that creates more friction for running tests locally, or at least running the integration tests locally.
In any case, I don't think we should block this fix on figuring out generated CA certs. That can come in a followup PR. Thoughts?
Specify certfile to verify SSL certs against in tests
|
there is a failing test: I think that the reason is that install-openldap creates self-signed CA certificate on VM setup, so I guess there is a more elegant way to handle this ... but this works as a quick fix |
|
@zmajstor see my original notes on the PR: certificates should be generated for tests, not checked in. I'm a big fan of the |
…none Specify certfile to verify SSL certs against in tests
#162 added a TLS Start test but didn't assert verified certs because the
tls_optionshadn't been wired up yet. #161 changed this, but hadn't been tested against the additional test in #162 before getting merged, resulting inmasterfailing.It's easy enough to disable certificate verification, but it's not necessary. Instead, we can also set the
:ca_fileTLS options to verify against.cc @jch @schaary @sonOfRa @tarcieri