Do not mention removed function-in-buffer#295
Merged
Conversation
rswgnu
approved these changes
Jan 7, 2023
eacce97 to
31ef40d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
function-in-buffer,org-modewithorg-link-outside-org-modeandibtypes::org-modefrom function index in hyperbole info pagesWhy
The function was removed in commit
81cebfec471ca72c8d0c9cbabc9c9bdd986c7117, See also emacs-bugThe implicit button for
org-modewas removed in commit5544a6c22b0bcc1c77970273f51fe521d56c5ff6in favor ofother ways to support org-mode, See also emacs-bug
Note
Not sure what makes sense here in documentation. If I understand correct smart-org have taken over the role of the implicit org-mode button. org-mode is still mentioned under implicit buttons in the info pages!? But the smart-key functionality is like implicit buttons. I think of them as the same concept wise more or less. So not sure if these changes require some modification to the docs or if we should just keep things as they are.