Use pattern substitution to derive the elc files#291
Merged
Conversation
rswgnu
requested changes
Dec 18, 2022
| kotl/kcell.elc kotl/kproperty.elc kotl/kview.elc kotl/kvspec.elc | ||
| ELC_COMPILE = $(EL_COMPILE:.el=.elc) | ||
|
|
||
| ELC_KOTL = $(EL_KOTL:.el=.elc) |
Owner
There was a problem hiding this comment.
You are missing the kotl/ prefix here.
Collaborator
Author
There was a problem hiding this comment.
No, I don't think so. This should be a pattern substitution, so for all words in the string ET_KOTL a matching end is replaced.
See https://github.com/rswgnu/hyperbole/actions/runs/3722317980/jobs/6313030557#step:4:29
and https://www.gnu.org/software/make/manual/html_node/Substitution-Refs.html
Owner
|
Got it. Thanks, I misread it.-- BobOn Dec 18, 2022, at 2:26 AM, Mats Lidell ***@***.***> wrote:
@matsl requested your review on: #291 Use pattern substitution to derive the elc files.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
rswgnu
approved these changes
Dec 18, 2022
rswgnu
approved these changes
Dec 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use pattern substitution to derive the elc files
Why
Makes the makefile cleaner and avoids the risk of an el-file not being compiled.
Note
There was one el-file that was not compiled.
hui-em-but.el. That might have been because of historical reasons. I can't see there would be any reason not to compile it now. The package manager will not care about the Makefile anyways to compiling it will be more close to the users build. Or am I missing something here?