Conversation
| (setq path (hpath:call | ||
| (lambda (path non-exist) | ||
| (let (modifier | ||
| (let ((modifier nil) |
There was a problem hiding this comment.
@rswgnu modifier is strange. Never set and used in call to two later concat calls. Code might be possible to clean up more so leaving this for you to look into if modifier can be removed and the concat calls simplified?
| (while (re-search-forward indent nil t) | ||
| (delete-region | ||
| (+ (match-beginning 0) 2) (match-end 0))))))) | ||
| pos) |
There was a problem hiding this comment.
pos does not look like it is used so removing it.
There was a problem hiding this comment.
You are right that it is not really used but it is sent in a call about 2 lines down but then the value is ignored in the called function as well. Let's push your updates and then I'll finish the changes here after.
| (while (re-search-forward indent nil t) | ||
| (delete-region | ||
| (+ (match-beginning 0) 2) (match-end 0))))))) | ||
| pos) |
There was a problem hiding this comment.
You are right that it is not really used but it is sent in a call about 2 lines down but then the value is ignored in the called function as well. Let's push your updates and then I'll finish the changes here after.
matsl
force-pushed
the
fix_lexical_dynamic_warnings
branch
from
972ed4d to
daa3031
Compare
2 participants
What
Fix lexical-dynamic warnings.
Why