Merged
Conversation
Owner
I agree. No need now. Let's see how it goes with the warnings re-enabled. |
rswgnu
requested changes
Oct 10, 2022
matsl
force-pushed
the
show_docstring_warnings_again
branch
from
479faf3 to
dc0fa24
Compare
matsl
force-pushed
the
show_docstring_warnings_again
branch
from
dc0fa24 to
d953d0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Show docstring warnings again.
Why
When docstring warnings are gone we need to keep them under control and echoing them when byte compiling is our best option. This PR makes the build show docstring warnings for the
binandelntargets.There is a flag that turns all warnings to errors but we have many more warnings still remaining so we are not ready for that yet I think. It can not be set to turn specific warnings to errors.
We could consider to implement our own checker that would parse (or grep) compilation output for specific warnings we want to fail the build on. For now that feels like over engineering. wdyt?