Doc strings within 80 char limit for hact.el#212
Merged
Conversation
rswgnu
requested changes
Jul 21, 2022
rswgnu
approved these changes
Jul 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Doc strings within 80 char limit for hact.el.
Why
Was part of PR but extracted to be less to review at a time.
Note
@rswgnu In the review view you can use the add a suggestion to provide a doc string that will allow me to just commit that directly from github UI. So no need to for me to cut and paste. This works well for review cases where there is a clear proposal of what to change as with doc strings.