Conversation
Remove arg checks and check for null replacement string for full compatibility with replace-regexp-in-string.
Remove test cases since they are not needed now when using replace-regexp-in-string.
rswgnu
approved these changes
Jul 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hypb:replace-match-stringwith Emacsreplace-regexp-in-string.Why
The internal hypb function is almost a perfect match with the standard function but with the order of the arguments slightly different which is a bit confusing. The functionality is further more based on
replace-regexp-in-stringwith a few checks performed before dispatching. These small checks does not seem to matter!? (Our unit tests does not complain anyway.)Note
Since we don't have 100% test coverage this type of change could be a bit dangerous. It is for that reason performed in steps with each commit providing some logic change. The test suite has been run during there commit steps to ensure that error cases are identified and fixed by later steps.
@rswgnu Maybe not a priority but I thought this would be a way to remove the test case that fails for 27.2 related to this functionality. I think you at some occasions been talking about doing this change and I wanted to see how difficult it would be,