Conversation
Removes some code that digs in the guts of functions, replacing it with cleaner `advice-add`. It also adds various FIXMEs about advice which should be removed/replaced (it's OK as a temporary measure but it should come *together* with a better long-term solution).
| (if (fboundp 'hproperty:but-create) | ||
| (progn (widen) (hproperty:but-create) | ||
| (rmail-show-message)))) | ||
| (if (boundp 'rmail-get-new-mail-post-hook) ;FIXME: Doesn't exist. XEmacs? |
There was a problem hiding this comment.
Not sure I understand. Does it mean that we need to see to that this works or that it must be kept?
Related: I can't find rmail-get-new-mail-post-hook neither in Emacs nor XEmacs in current and historic data I have access to.
There was a problem hiding this comment.
It may be something I added when I redid rmail and rmailsum years ago but not sure if it was merged to mainline. I guess it doesn't matter at this point.
| (hypb:function-symbol-replace | ||
| constant sym-to-replace replace-with-sym)))))) | ||
|
|
||
| (defun hypb:insert-hyperbole-banner () |
There was a problem hiding this comment.
Check that all the removed fun ctions above are no longer called anywhere.
Add Changelog entries for all major file-level changes.
There was a problem hiding this comment.
Verified that all deleted functions are by this PR not use somewhere else.
Noticed while looking at Stefans mail again that ChangeLog entries were provided already by Stefan so I reused those. (Wasted time by providing my own ChangeLog entries. Can be viewed in separate commit. 😄 )
| @@ -71,13 +71,6 @@ | |||
| (gnus-summary-display-article article)))) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@rswgnu gnus-inews-article seems to have been removed since long. So this would be a bug for us to still depend on it. As we have spoken about before the gnus/message support should probably get a complete overlook and is probably broken. Not sure what is the best approach here. I guess using functionality that does not exists does not make sense and is misleading so for the short term it might be OK to just remove it!?
2 participants
What
Stefans patch.
Removes some code that digs in the guts of functions, replacing it
with cleaner
advice-add.It also adds various FIXMEs about advice which should be
removed/replaced (it's OK as a temporary measure but it should come
together with a better long-term solution).