Skip to content

Use messages-buffer, run test case only interactively#205

Merged
matsl merged 1 commit intomasterfrom
minor-test-changes
Jul 12, 2022
Merged

Use messages-buffer, run test case only interactively#205
matsl merged 1 commit intomasterfrom
minor-test-changes

Conversation

@matsl
Copy link
Copy Markdown
Collaborator

@matsl matsl commented Jul 11, 2022

What

Use messages-buffer for getting the *Messages* buffer and run test case hui-select--thing only interactively.

Why

  • Elisp manual suggest not using the string *Messages* but instead use the function messages-buffer.
  • Output in batch mode goes to stdout and not *Messages* so test cases reading *Messages* should not be run non interactively (But oddly it seems to work anyway under some circumstances. Anyway test-all is the preferred method to run test cases so this will just ensure that when make test is used it will not fail. This happens when run in a docker container and is useful for quick tests.)

@matsl matsl requested a review from rswgnu July 11, 2022 21:53
@matsl matsl merged commit e85b09b into master Jul 12, 2022
@matsl matsl deleted the minor-test-changes branch July 12, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants