Merged
Conversation
matsl
force-pushed
the
remove_last_mentioning_xemacs
branch
from
0ce88c4 to
5a2ccbd
Compare
rswgnu
requested changes
Jul 16, 2022
Owner
rswgnu
left a comment
rswgnu
left a comment
There was a problem hiding this comment.
See inline comment on version numbers. Approved once you make that change.
| (defalias 'kotl-mode:beginning-of-line 'kotl-mode:to-start-of-line) | ||
| (defalias 'kotl-mode:beginning-of-visual-line 'kotl-mode:to-start-of-line) | ||
| (define-obsolete-function-alias 'kotl-mode:to-start-of-line #'kotl-mode:beginning-of-line "9.0") | ||
| (defalias 'kotl-mode:beginning-of-visual-line 'kotl-mode:beginning-of-line) |
Owner
There was a problem hiding this comment.
Would prefer version 8.0.1 when you make any versioned changes since these will be in that release.
Collaborator
Author
There was a problem hiding this comment.
Yes. I misunderstood the WHEN parameter to be when the alias would be removed and thus effectively remove the old function. Looking now I understand it is when the it is first marked as obsolete so 8.0.1 make perfect sense. Thanks for pointing that out. I will fix.
Collaborator
Author
There was a problem hiding this comment.
Noticed that I marked hypb:replace-match-string as obsolete from 9.0 as well. So I fixed this with this PR too.
Was not used due to legacy XEmacs byte compiler bug. Marked old name kotl-mode:to-start-of-line as obsolete from version 9.0
This is the next release so it is when newly obsolete functions first will be marked as obsolete.
matsl
force-pushed
the
remove_last_mentioning_xemacs
branch
from
84cc725 to
e1be973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove last mentioning xemacs.
Why
Since XEmacs is not supported it is strange to have code and comments that mentions XEmacs.
Note
This PR has two parts: