Merged
Conversation
Warning is related to running under 24.2 or older, which we do not support, so only cosmetics!?
See "(elisp)Coding conventions"
rswgnu
approved these changes
Jun 14, 2022
ChangeLog
Outdated
|
|
||
| * hibtypes.el (cl-lib): Require cl-lib to remove package-lint warning. | ||
|
|
||
| * hyperbole.el: Remove defalias for compatilility with obsolete functions |
ChangeLog
Outdated
| * hyperbole.el: Remove defalias for compatilility with obsolete functions | ||
| since Emacs 25.1 and outline-flag-region available since 2003. | ||
|
|
||
| * hui-em-but.el (hproperty:good-colors): package-lint code formating. |
Collaborator
Author
There was a problem hiding this comment.
I must start with having the spell checker active in the commit window. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix some package lint messages.
Why
Some or the reaming issues looked small so I gave it a try.
Some are really hard, impossible!?, to fix since we change function in other packages. I supposed that would require some help from the packages we modify to support some hooks or similar for those changes to be possible cleanly!?
Note
Each type of change is in a separate commit except for the ChangeLog and copyright year update that tend to be afterthoughts in my case and comes together as the last commit.